Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialogs libraries - adaptive runtime #4239

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-dialogs-adaptive-runtime library.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Fix spacing
    • Fix indentation
    • Add blank line in between comments
  • Applied manual fixes for:
    • Missing documentation

Testing

Library eslint status
Screenshot 2022-05-04 141033

Library tests status
Screenshot 2022-05-04 141015

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 12, 2022 16:40
@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2314802491

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.48%

Totals Coverage Status
Change from base Build 2245574340: -0.003%
Covered Lines: 19902
Relevant Lines: 22310

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a8d076e into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-rest-of-botbuilder-dialogs-adaptive-runtime branch July 13, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants